Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

premint v2 sdk #387

Closed
wants to merge 7 commits into from
Closed

premint v2 sdk #387

wants to merge 7 commits into from

Conversation

oveddan
Copy link
Collaborator

@oveddan oveddan commented Nov 22, 2023

Premint sdk now supports premint v2. See the added changeset for a summary of changes.

ToDo:

  • Check when creating premints, that the premint version is supported by the contract. if v2 is supported by the contract, then require premint to be created as a v2 signature

@oveddan
Copy link
Collaborator Author

oveddan commented Nov 22, 2023

Current dependencies on/for this PR:

This stack of pull requests is managed by Graphite.

@oveddan oveddan mentioned this pull request Nov 22, 2023
keccak256(
abi.encode(ATTRIBUTION_DOMAIN_V1, _hashToken(premintConfig.tokenConfig), premintConfig.uid, premintConfig.version, premintConfig.deleted)
);
function hashPremint(TokenCreationConfig memory tokenConfig, PremintSettings memory settings) internal pure returns (bytes32) {
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this file change doens't belong in this PR

Base automatically changed from deploy-2.5.2-testnets to fix-premint-v2-encoding November 27, 2023 17:22
@oveddan oveddan changed the base branch from fix-premint-v2-encoding to main November 27, 2023 17:38
@@ -2,7 +2,7 @@ name: Lint
on: [pull_request]

jobs:
inspect-storage:
lint:
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should this be another PR?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes - will do

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done in #391

@oveddan oveddan changed the base branch from main to protocol-sdk-split-up-1155-and-721-mint November 28, 2023 20:48
Base automatically changed from protocol-sdk-split-up-1155-and-721-mint to main November 28, 2023 20:49
@oveddan oveddan changed the base branch from main to minimal-premint-client-refactor November 28, 2023 22:46
Base automatically changed from minimal-premint-client-refactor to main November 28, 2023 23:29
@oveddan oveddan force-pushed the premint-v2-auth-check-change branch 2 times, most recently from 4a70aaf to 0a5abb4 Compare November 28, 2023 23:33
@oveddan oveddan changed the base branch from main to fix-lint-task November 29, 2023 18:34
@oveddan oveddan mentioned this pull request Nov 29, 2023
Base automatically changed from fix-lint-task to main November 29, 2023 22:38
export type PremintConfigV2 = PremintV2HashDataTypes[1];
export type TokenCreationConfigV2 = PremintConfigV2["tokenConfig"];

const v1Types = {
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: Should we put this into another file?

@oveddan oveddan closed this Nov 30, 2023
@oveddan oveddan deleted the premint-v2-auth-check-change branch November 30, 2023 19:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants